Skip to content

fix(core): prefer vertical layout categorically if there are less tha… #31221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented May 14, 2025

…n 75 characters of width

Current Behavior

Auto layout is always based on an aspect ratio which lead to horizontal layout even when there is very little horizontal space.

Expected Behavior

Auto layout prefers vertical layout with less than 75 characters of width which will allow 50 characters (75 * 2/3) for terminal output. It should be enough to show a URL in most cases:

image
image

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team as code owners May 14, 2025 21:32
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 16, 2025 6:55pm

Copy link

nx-cloud bot commented May 14, 2025

View your CI Pipeline Execution ↗ for commit b8f325a.


☁️ Nx Cloud last updated this comment at 2025-05-16 18:53:35 UTC

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense, we can definitely refine the auto detection a lot further, the initial work just got the "plumbing" in place. Please add a snapshot test for this

@FrozenPandaz FrozenPandaz requested a review from JamesHenry May 16, 2025 18:55
@FrozenPandaz FrozenPandaz dismissed JamesHenry’s stale review May 16, 2025 18:56

Added the snapshots :)

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) May 16, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants