fix(core): use v8 serializer in v19

packages/nx/src/command-line/daemon/daemon.ts

@@ -2,6 +2,7 @@ import type { Arguments } from 'yargs';
 import { DAEMON_OUTPUT_LOG_FILE } from '../../daemon/tmp-dir';
 import { output } from '../../utils/output';
 import { generateDaemonHelpOutput } from '../../daemon/client/generate-help-output';
+import { daemonClient } from '../../daemon/client/client';
 
 export async function daemonHandler(args: Arguments) {
   if (args.start) {

packages/nx/src/daemon/client/client.ts

@@ -77,6 +77,8 @@ import {
   FLUSH_SYNC_GENERATOR_CHANGES_TO_DISK,
   type HandleFlushSyncGeneratorChangesToDiskMessage,
 } from '../message-types/flush-sync-generator-changes-to-disk';
+import { deserialize } from 'node:v8';
+import { isJsonMessage } from '../../utils/consume-messages-from-socket';
 
 const DAEMON_ENV_SETTINGS = {
   NX_PROJECT_GLOB_CACHE: 'false',
@@ -227,7 +229,10 @@ export class DaemonClient {
     return this.sendToDaemonViaQueue({
       type: 'HASH_TASKS',
       runnerOptions,
-      env,
+      env:
+        process.env.NX_USE_V8_SERIALIZER !== 'false'
+          ? structuredClone(process.env)
+          : env,
       tasks,
       taskGraph,
     });
@@ -265,7 +270,9 @@ export class DaemonClient {
       ).listen(
         (message) => {
           try {
-            const parsedMessage = JSON.parse(message);
+            const parsedMessage = isJsonMessage(message)
+              ? JSON.parse(message)
+              : deserialize(Buffer.from(message, 'binary'));
             callback(null, parsedMessage);
           } catch (e) {
             callback(e, null);
@@ -543,21 +550,23 @@ export class DaemonClient {
 
   private handleMessage(serializedResult: string) {
     try {
-      performance.mark('json-parse-start');
-      const parsedResult = JSON.parse(serializedResult);
-      performance.mark('json-parse-end');
+      performance.mark('result-parse-start');
+      const parsedResult = isJsonMessage(serializedResult)
+        ? JSON.parse(serializedResult)
+        : deserialize(Buffer.from(serializedResult, 'binary'));
+      performance.mark('result-parse-end');
       performance.measure(
         'deserialize daemon response',
-        'json-parse-start',
-        'json-parse-end'
+        'result-parse-start',
+        'result-parse-end'
       );
       if (parsedResult.error) {
         this.currentReject(parsedResult.error);
       } else {
         performance.measure(
           'total for sendMessageToDaemon()',
           'sendMessageToDaemon-start',
-          'json-parse-end'
+          'result-parse-end'
         );
         return this.currentResolve(parsedResult);
       }

packages/nx/src/daemon/client/daemon-socket-messenger.ts

@@ -1,7 +1,10 @@
-import { randomUUID } from 'crypto';
+import { serialize } from 'v8';
 import { Socket } from 'net';
 import { performance } from 'perf_hooks';
-import { consumeMessagesFromSocket } from '../../utils/consume-messages-from-socket';
+import {
+  consumeMessagesFromSocket,
+  MESSAGE_END_SEQ,
+} from '../../utils/consume-messages-from-socket';
 
 export interface Message extends Record<string, any> {
   type: string;
@@ -12,9 +15,14 @@ export class DaemonSocketMessenger {
   constructor(private socket: Socket) {}
 
   async sendMessage(messageToDaemon: Message) {
-    this.socket.write(JSON.stringify(messageToDaemon));
+    if (process.env.NX_USE_V8_SERIALIZER !== 'false') {
+      const serialized = serialize(messageToDaemon);
+      this.socket.write(serialized.toString('binary'));
+    } else {
+      this.socket.write(JSON.stringify(messageToDaemon));
+    }
     // send EOT to indicate that the message has been fully written
-    this.socket.write(String.fromCodePoint(4));
+    this.socket.write(MESSAGE_END_SEQ);
   }
 
   listen(

packages/nx/src/daemon/server/file-watching/file-watcher-sockets.ts

@@ -89,14 +89,18 @@ export function notifyFileWatcherSockets(
         }
 
         if (changedProjects.length > 0 || changedFiles.length > 0) {
-          return handleResult(socket, 'FILE-WATCH-CHANGED', () =>
-            Promise.resolve({
-              description: 'File watch changed',
-              response: JSON.stringify({
-                changedProjects,
-                changedFiles,
+          return handleResult(
+            socket,
+            'FILE-WATCH-CHANGED',
+            () =>
+              Promise.resolve({
+                description: 'File watch changed',
+                response: JSON.stringify({
+                  changedProjects,
+                  changedFiles,
+                }),
               }),
-            })
+            'json'
           );
         }
       })

packages/nx/src/daemon/server/handle-context-file-data.ts

@@ -5,7 +5,7 @@ import { HandlerResult } from './server';
 export async function handleContextFileData(): Promise<HandlerResult> {
   const files = await getAllFileDataInContext(workspaceRoot);
   return {
-    response: JSON.stringify(files),
+    response: files,
     description: 'handleContextFileData',
   };
 }

packages/nx/src/daemon/server/handle-flush-sync-generator-changes-to-disk.ts

@@ -7,7 +7,7 @@ export async function handleFlushSyncGeneratorChangesToDisk(
   const result = await flushSyncGeneratorChangesToDisk(generators);
 
   return {
-    response: JSON.stringify(result),
+    response: result,
     description: 'handleFlushSyncGeneratorChangesToDisk',
   };
 }

packages/nx/src/daemon/server/handle-get-files-in-directory.ts

@@ -7,7 +7,7 @@ export async function handleGetFilesInDirectory(
 ): Promise<HandlerResult> {
   const files = await getFilesInDirectoryUsingContext(workspaceRoot, dir);
   return {
-    response: JSON.stringify(files),
+    response: files,
     description: 'handleNxWorkspaceFiles',
   };
 }

packages/nx/src/daemon/server/handle-get-registered-sync-generators.ts

@@ -5,7 +5,7 @@ export async function handleGetRegisteredSyncGenerators(): Promise<HandlerResult
   const syncGenerators = await getCachedRegisteredSyncGenerators();
 
   return {
-    response: JSON.stringify(syncGenerators),
+    response: syncGenerators,
     description: 'handleGetSyncGeneratorChanges',
   };
 }

packages/nx/src/daemon/server/handle-get-sync-generator-changes.ts

@@ -18,7 +18,7 @@ export async function handleGetSyncGeneratorChanges(
   );
 
   return {
-    response: JSON.stringify(result),
+    response: result,
     description: 'handleGetSyncGeneratorChanges',
   };
 }

packages/nx/src/daemon/server/handle-glob.ts

@@ -8,7 +8,7 @@ export async function handleGlob(
 ): Promise<HandlerResult> {
   const files = await globWithWorkspaceContext(workspaceRoot, globs, exclude);
   return {
-    response: JSON.stringify(files),
+    response: files,
     description: 'handleGlob',
   };
 }

packages/nx/src/daemon/server/handle-hash-tasks.ts

@@ -47,8 +47,10 @@ export async function handleHashTasks(payload: {
       payload.runnerOptions
     );
   }
-  const response = JSON.stringify(
-    await storedHasher.hashTasks(payload.tasks, payload.taskGraph, payload.env)
+  const response = await storedHasher.hashTasks(
+    payload.tasks,
+    payload.taskGraph,
+    payload.env
   );
   return {
     response,

packages/nx/src/daemon/server/handle-nx-workspace-files.ts

@@ -10,7 +10,7 @@ export async function handleNxWorkspaceFiles(
     projectRootMap
   );
   return {
-    response: JSON.stringify(files),
+    response: files,
     description: 'handleNxWorkspaceFiles',
   };
 }

packages/nx/src/daemon/server/handle-outputs-tracking.ts

@@ -31,7 +31,7 @@ export async function handleOutputsHashesMatch(payload: {
       payload.data.hash
     );
     return {
-      response: JSON.stringify(res),
+      response: res,
       description: 'outputsHashesMatch',
     };
   } catch (e) {

packages/nx/src/daemon/server/handle-task-history.ts

@@ -14,7 +14,7 @@ export async function handleGetFlakyTasks(hashes: string[]) {
   const taskHistory = getTaskHistory();
   const history = await taskHistory.getFlakyTasks(hashes);
   return {
-    response: JSON.stringify(history),
+    response: history,
     description: 'handleGetFlakyTasks',
   };
 }
@@ -23,7 +23,7 @@ export async function handleGetEstimatedTaskTimings(targets: TaskTarget[]) {
   const taskHistory = getTaskHistory();
   const history = await taskHistory.getEstimatedTaskTimings(targets);
   return {
-    response: JSON.stringify(history),
+    response: history,
     description: 'handleGetEstimatedTaskTimings',
   };
 }