Skip to content

feat(angular): generate components without a .component/Component suffix/type #31233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 15, 2025

  • Update generators to generate components without the .component/Component suffix/type by default for Angular v20
  • Keep the ability to generate components with the .component/Component suffix/type by providing the type option for the @nx/angular:component and @nx/angular:scam generators
  • When the workspace uses a version lower than v20, the generators will still generate components with the .component/Component suffix/type by default

Note: a migration will be provided in a separate PR so existing workspaces continue generating components with the .component/Component suffix/type.

@leosvelperez leosvelperez requested a review from Coly010 May 15, 2025 14:26
@leosvelperez leosvelperez self-assigned this May 15, 2025
@leosvelperez leosvelperez requested review from a team as code owners May 15, 2025 14:26
@leosvelperez leosvelperez requested a review from jaysoo May 15, 2025 14:26
Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 16, 2025 8:15am

Copy link

nx-cloud bot commented May 15, 2025

View your CI Pipeline Execution ↗ for commit 0d70f41.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 26m 24s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 08:37:51 UTC

@leosvelperez leosvelperez force-pushed the angular/v20-components-without-type branch from 4620b40 to 0d70f41 Compare May 16, 2025 08:05
@leosvelperez leosvelperez merged commit 1070e18 into angular/v20 May 16, 2025
6 checks passed
@leosvelperez leosvelperez deleted the angular/v20-components-without-type branch May 16, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants