Merged
Conversation
marshallmcdonnell
approved these changes
Dec 3, 2025
Collaborator
marshallmcdonnell
left a comment
marshallmcdonnell
left a comment
There was a problem hiding this comment.
Awesome!
I checked both dashboard and proxy, both have https!
Great work.
ArgoCD is great and I love the idea!
We have tried it out a few times in prototype but never got to fully using it all the time due to learning curve / proper setup in our local clusters.
But this is perfect for public cloud / your NSDF cluster!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds https support for the ingress. This adds the necessary annotations and specs to the ingress for further deployments. Closes #32
Cert-manager
cert-manager was deployed into the cluster. Tested letsencrypt staging issuer CRD, and then deployed the production issuer, it generated the certificate correctly.
Implementation Notes
Since v1.18 of cert-manager the ACME http01 challenge paths use
pathType: exactdocumented here, this will cause it to break since we usepathType: ImplementationSpecificand is currently has a bug with the nginx controller version we have.I applied the helm chart for cert-manager with values from option 1 to fix it.
https://intersect.nationalsciencedatafabric.org/dashboard now has TLS cert.
A few CRDs have been applied namely the Issuers for letsencrypt both staging and prod.
Other
I've been looking into Argo for CD. It can be good considering there are quite a few CRDs now applied and helm charts that bootstrap the cluster.