Changes as of 04/01 (mod2) #3
Conversation
|
I have completed these changes, pending discussions above. LMK how it's looking. |
|
Er one more change. @josevalim also in case you don't get notified by github of this PR. No hurry of course. |
|
Will review tomorrow morning again, apologies :) |
|
|
||
| conn | ||
| |> put_token_in_session(new_token) | ||
| |> maybe_refresh_remember_me_cookie(new_token) |
There was a problem hiding this comment.
Note to self: this is very close to the login function, we should probably break the login function in two, one which logs in and the other that logs in and redirect. But we want to make other changes to that function, so we will do this later. :) No action needed from you.
|
We are good to go!!!! Just minor nits. Thank you! |
|
Great! I'll fix up those few things, then transfer it to the templates to output the same thing. I'll create a new PR in phoenix to keep the history clean, and just reference the old PR and this PR for context. |
No description provided.