Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality: 5
Documentation: 5
Style: 5
Total: 5/5
This looks awesome! Your code is easy to read and well-structured, your documentation is clear, and the output is interesting to explore (the interactivity is a nice touch).
Two style comments:
if __name__ == "__main__"structure, which lets you run code onpython relationship_map.pybut not onimport relationship_map. This isn't directly applicable to the scope of your project, but it's useful for larger-scale modularity.from pattern.web import *won't slow your code down noticeably, but if you did something like that many times throughout a larger program, it would.Also: it's polite to include a README with instructions for installing dependencies (I had most of them already, but I had to
pip install selenium).Look through the files changed to see more comments about specifics in your code. Feel free to respond to the comments inline -- more than happy to have a conversation.
Once you've read the comments, make a comment to the pull request letting us know that you've checked them out. Afterwards, close the PR.
REMEMBER NOT TO MERGE THESE PRs!