shape paramEffect handling for TemplateSample #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmith-
reviewed
Jun 8, 2023
| if param.combinePrior == 'lnN': | ||
| return 1. / self._paramEffectsUp[param] | ||
| elif param.combinePrior == 'shape': | ||
| return self._nominal - abs(self._nominal - self._paramEffectsUp[param]) |
Owner
There was a problem hiding this comment.
For shape the effect is truly additive rather than multiplicative as far as I remember. So I don't understand the last divide by nominal step
Owner
There was a problem hiding this comment.
Did you get a chance to check this? Or do I misunderstand?
Collaborator
Author
There was a problem hiding this comment.
Sorry for the late response.
I did not have a chance to look into this again. I will try to do so this week.
Owner
|
Sorry for the delay. I for some reason don't get notifications on this library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I encountered a apparently rare situation when building TemplateSamples with shape nuisances using histograms as up/down effect, where both the norm of the nominal and up/down hists is ~1.
First part is that paramEffectUp is saved even if the effect is nil (i.e.
np.all(effect_up==1)) whenever one gives also something notNoneas effect_down even ifnp.all(effect_down==1). Thats why I moved the lineself._paramEffectsUp[param] = effect_updown to the point where the check if the down-variation is different from 1 has been done.Second part is in the symmetrisation of the paramEffect if
effect_downis None for a parameter. In the functionsetParamEffecteffects for a shape param are stored as relatives but here it is handled as absolutes, if i understand this correctly.So whenever one would provide only the param up-effect the constructed down-effect could be some bogus negative array. Which happened to me before i fixed the first part.
Does it make sense to fix it like this, or am i missing something?