forked from vercel/next.js
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: improve PR labeling, fix, sort, add new team member (vercel#46675
) ## What? This PR has its main goal to improve the experience of opening/reviewing a PR. It improves the PR template, as well as extends PR auto-labeling. ## Why? There are 2 parts to the PR template: - Individual contributors: The current template accommodates for the most common cases individual contributors use to contribute. (I.e. fixing bugs, updating/adding examples, addressing documentation issues). The new template keeps this at the top. - Next.js team: As maintainers, we should try to explain PRs as if someone with less context would review them. This should also help with backreferencing PRs in issues and follow-up PRs and make it easier to follow changes, understand trade-offs better at the time, and help new team members catch up over time, etc. ## How? The template is written in a comment instead of Markdown, so when the PR is opened, most of the template is hidden to make it less verbose. The checkboxes we've had before are not shown, but we already auto-label PRs based on the path of the files that have been touched, so the checkboxes showed redundant information. [Slack thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1677677802109289), Closes NEXT-741
- Loading branch information
1 parent
a5a13fe
commit f1fba5b
Showing
2 changed files
with
80 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,53 +1,65 @@ | ||
| { | ||
| "labels": { | ||
| "area: examples": ["examples/**"], | ||
| "area: documentation": ["docs/**", "errors/**"], | ||
| "area: create-next-app": ["packages/create-next-app/**"], | ||
| "type: next": [ | ||
| "packages/next/**", | ||
| "packages/react-dev-overlay/**", | ||
| "packages/react-refresh-utils/**", | ||
| "packages/next-codemod/**", | ||
| "packages/eslint-plugin-next/**", | ||
| "packages/eslint-config-next/**", | ||
| "packages/next-env/**", | ||
| "packages/next-swc/**" | ||
| "area: documentation": ["docs/**", "errors/**"], | ||
| "area: examples": ["examples/**"], | ||
| "area: next/image": [ | ||
| "**/*image*", | ||
| "**/*image*/**", | ||
| "packages/next/src/client/use-intersection.tsx", | ||
| "packages/next/src/server/lib/squoosh/", | ||
| "packages/next/src/server/serve-static.ts" | ||
| ], | ||
| "area: Font Optimization": ["**/*font*"], | ||
| "area: tests": ["test/**", "bench/**"], | ||
| "created-by: Chrome Aurora": [ | ||
| { "type": "user", "pattern": "spanicker" }, | ||
| { "type": "user", "pattern": "housseindjirdeh" }, | ||
| { "type": "user", "pattern": "atcastle" }, | ||
| { "type": "user", "pattern": "devknoll" }, | ||
| { "type": "user", "pattern": "housseindjirdeh" }, | ||
| { "type": "user", "pattern": "janicklas-ralph" }, | ||
| { "type": "user", "pattern": "atcastle" }, | ||
| { "type": "user", "pattern": "kara" }, | ||
| { "type": "user", "pattern": "kyliau" }, | ||
| { "type": "user", "pattern": "kara" } | ||
| { "type": "user", "pattern": "spanicker" } | ||
| ], | ||
| "created-by: Next.js team": [ | ||
| { "type": "user", "pattern": "acdlite" }, | ||
| { "type": "user", "pattern": "balazsorban44" }, | ||
| { "type": "user", "pattern": "Brooooooklyn" }, | ||
| { "type": "user", "pattern": "feedthejim" }, | ||
| { "type": "user", "pattern": "ForsakenHarmony" }, | ||
| { "type": "user", "pattern": "gnoff" }, | ||
| { "type": "user", "pattern": "hanneslund" }, | ||
| { "type": "user", "pattern": "huozhi" }, | ||
| { "type": "user", "pattern": "ijjk" }, | ||
| { "type": "user", "pattern": "JanKaifer" }, | ||
| { "type": "user", "pattern": "kdy1" }, | ||
| { "type": "user", "pattern": "kwonoj" }, | ||
| { "type": "user", "pattern": "leerob" }, | ||
| { "type": "user", "pattern": "padmaia" }, | ||
| { "type": "user", "pattern": "huozhi" }, | ||
| { "type": "user", "pattern": "sebmarkbage" }, | ||
| { "type": "user", "pattern": "shuding" }, | ||
| { "type": "user", "pattern": "sokra" }, | ||
| { "type": "user", "pattern": "styfle" }, | ||
| { "type": "user", "pattern": "leerob" }, | ||
| { "type": "user", "pattern": "kdy1" }, | ||
| { "type": "user", "pattern": "timneutkens" }, | ||
| { "type": "user", "pattern": "sebmarkbage" }, | ||
| { "type": "user", "pattern": "wyattjoh" }, | ||
| { "type": "user", "pattern": "kwonoj" }, | ||
| { "type": "user", "pattern": "gnoff" }, | ||
| { "type": "user", "pattern": "padmaia" }, | ||
| { "type": "user", "pattern": "Brooooooklyn" }, | ||
| { "type": "user", "pattern": "ForsakenHarmony" }, | ||
| { "type": "user", "pattern": "feedthejim" }, | ||
| { "type": "user", "pattern": "JanKaifer" }, | ||
| { "type": "user", "pattern": "balazsorban44" }, | ||
| { "type": "user", "pattern": "hanneslund" } | ||
| { "type": "user", "pattern": "wyattjoh" } | ||
| ], | ||
| "created-by: Next.js docs team": [ | ||
| { "type": "user", "pattern": "ismaelrumzan" }, | ||
| { "type": "user", "pattern": "MaedahBatool" }, | ||
| { "type": "user", "pattern": "molebox" }, | ||
| { "type": "user", "pattern": "ismaelrumzan" } | ||
| { "type": "user", "pattern": "molebox" } | ||
| ], | ||
| "type: next": [ | ||
| "packages/eslint-config-next/**", | ||
| "packages/eslint-plugin-next/**", | ||
| "packages/font/**", | ||
| "packages/next-bundle-analyzer/**", | ||
| "packages/next-codemod/**", | ||
| "packages/next-env/**", | ||
| "packages/next-mdx/**", | ||
| "packages/next-swc/**", | ||
| "packages/next/**", | ||
| "packages/react-dev-overlay/**", | ||
| "packages/react-refresh-utils/**" | ||
| ] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,45 @@ | ||
| <!-- | ||
| Thanks for opening a PR! Your contribution is much appreciated. | ||
| <!-- Thanks for opening a PR! Your contribution is much appreciated. | ||
| To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. | ||
| Choose the right checklist for the change(s) that you're making: | ||
| --> | ||
| ## Bug | ||
| ## For Contributors | ||
| ### Improving Documentation or adding/fixing Examples | ||
| - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md | ||
| - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md | ||
| ### Fixing a bug | ||
| - Related issues linked using `fixes #number` | ||
| - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs | ||
| - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md | ||
| ### Adding a feature | ||
| - [ ] Related issues linked using `fixes #number` | ||
| - [ ] Integration tests added | ||
| - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) | ||
| - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) | ||
| - Related issues/discussions are linked using `fixes #number` | ||
| - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs | ||
| - Documentation added | ||
| - Telemetry added. In case of a feature if it's used or not. | ||
| - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md | ||
| ## Feature | ||
| - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. | ||
| - [ ] Related issues linked using `fixes #number` | ||
| - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added | ||
| - [ ] Documentation added | ||
| - [ ] Telemetry added. In case of a feature if it's used or not. | ||
| - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) | ||
| ## Documentation / Examples | ||
| ## For Maintainers | ||
| - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` | ||
| - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) | ||
| - Minimal description (aim for explaining to someone not on the team to understand the PR) | ||
| - When linking to a Slack thread, you might want to share details of the conclusion | ||
| - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues | ||
| - Add review comments if necessary to explain to the reviewer the logic behind a change | ||
| ### What? | ||
| ### Why? | ||
| ### How? | ||
| Closes NEXT- | ||
| Fixes # | ||
| --> |