Mqtt client 'offline' callback and fix small issue in getMessage method#11
Open
kenny59 wants to merge 2 commits intontkhang03:masterfrom
Open
Mqtt client 'offline' callback and fix small issue in getMessage method#11kenny59 wants to merge 2 commits intontkhang03:masterfrom
kenny59 wants to merge 2 commits intontkhang03:masterfrom
Conversation
|
This is what I've been looking for all this time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My bot was not responding after (each day after 5-8 hours of running) a while and it turns out that I was getting
'offline' callbackfrom mqtt client, which fb-chat-api is not subscribed to.I could not replicate it by unplugging any cables or disconnecting from internet, so it is most likely something that comes from Facebook itself.
Bumping mqtt client was not neccessary in the end, but it should contain some under the hood fixes that should make it more reliable.
Also this contains a small fix that fixes
getMessagewhen requesting a message that contains attachment.