Remove psalm in favor of phpstan

.gitattributes

@@ -3,8 +3,6 @@ infection.json          export-ignore
 Makefile                export-ignore
 phpstan.neon.dist       export-ignore
 phpstan-baseline.neon   export-ignore
-psalm-baseline.xml      export-ignore
-psalm.xml               export-ignore
 phpunit.xml.dist        export-ignore
 /docs                   export-ignore
 /tests                  export-ignore

.php-cs-fixer.dist.php

@@ -48,7 +48,7 @@
            'import_functions' => false,
         ],
         'phpdoc_to_comment' => [
-            'ignored_tags' => ['psalm-suppress'],
+            'ignored_tags' => [],
         ],
     ])
     ->setFinder($finder)

Makefile

@@ -32,10 +32,6 @@ cs: vendor-bin/tools/vendor
 cs-fix: vendor-bin/tools/vendor
 	vendor/bin/php-cs-fixer fix --verbose
 
-.PHONY: psalm
-psalm: vendor-bin/tools/vendor
-	vendor/bin/psalm --config=psalm.xml --diff --shepherd --show-info=false --stats --threads=4
-
 .PHONY: phpstan
 phpstan: vendor-bin/tools/vendor
 	vendor/bin/phpstan analyse

src/Action/RegistrationConfirmedAction.php

@@ -62,7 +62,7 @@ private function getTargetUrlFromSession(SessionInterface $session): ?string
             return null;
         }
 
-        $key = sprintf('_security.%s.target_path', $token->getProviderKey());
+        $key = \sprintf('_security.%s.target_path', $token->getProviderKey());
 
         if ($session->has($key)) {
             return $session->get($key);

src/DependencyInjection/Configuration.php

@@ -31,7 +31,6 @@ public function getConfigTreeBuilder(): TreeBuilder
 
     private function addRegistrationSection(ArrayNodeDefinition $node): void
     {
-        /** @psalm-suppress UndefinedInterfaceMethod */
         $node
             ->children()
                 ->arrayNode('registration')
@@ -52,7 +51,6 @@ private function addRegistrationSection(ArrayNodeDefinition $node): void
 
     private function addServiceSection(ArrayNodeDefinition $node): void
     {
-        /** @psalm-suppress UndefinedInterfaceMethod */
         $node
             ->addDefaultsIfNotSet()
             ->children()

src/Event/GetResponseRegistrationEvent.php

@@ -24,7 +24,7 @@ final class GetResponseRegistrationEvent extends Event
 
     private ?Response $response = null;
 
-    public function __construct(UserInterface $user, Request $request = null)
+    public function __construct(UserInterface $user, ?Request $request = null)
     {
         $this->user    = $user;
         $this->request = $request;

src/Mailer/Mail/RegistrationMail.php

@@ -22,7 +22,7 @@ final class RegistrationMail extends TemplatedEmail
 
     private UserInterface $user;
 
-    public function __construct(Headers $headers = null, AbstractPart $body = null)
+    public function __construct(?Headers $headers = null, ?AbstractPart $body = null)
     {
         parent::__construct($headers, $body);
 

tests/DependencyInjection/NucleosProfileExtensionTest.php

@@ -79,7 +79,7 @@ private function getFullConfig(): array
 
     private function assertAlias(string $value, string $key): void
     {
-        self::assertSame($value, (string) $this->configuration->getAlias($key), sprintf('%s alias is correct', $key));
+        self::assertSame($value, (string) $this->configuration->getAlias($key), \sprintf('%s alias is correct', $key));
     }
 
     private function assertHasDefinition(string $id): void

tests/Functional/Action/RegistrationWebTest.php

@@ -81,7 +81,7 @@ private function performRegister(KernelBrowser $client): void
 
     private function performConfirm(KernelBrowser $client, TestUser $user): void
     {
-        $client->request('GET', sprintf('/register/confirm/%s', $user->getConfirmationToken()));
+        $client->request('GET', \sprintf('/register/confirm/%s', $user->getConfirmationToken()));
 
         self::assertResponseRedirects('/register/confirmed');
 

tests/Functional/DoctrineSetupTrait.php

@@ -23,7 +23,7 @@ trait DoctrineSetupTrait
      * @param string[] $roles
      */
     public static function createUser(
-        string $username = null,
+        ?string $username = null,
         array $roles = []
     ): TestUser {
         $entity = new TestUser();
@@ -32,7 +32,7 @@ public static function createUser(
         $username ??= ('my-user'.$entity->getId());
 
         $entity->setUsername($username);
-        $entity->setEmail(sprintf('%[email protected]', $username));
+        $entity->setEmail(\sprintf('%[email protected]', $username));
         $entity->setRoles($roles);
 
         return $entity;

tests/Resources/XliffTest.php

@@ -40,7 +40,7 @@ public function testXliff(string $locale): void
         $this->validateXliff($locale);
 
         if (\count($this->errors) > 0) {
-            self::fail(sprintf('Unable to parse xliff files: %s', implode(', ', $this->errors)));
+            self::fail(\sprintf('Unable to parse xliff files: %s', implode(', ', $this->errors)));
         }
     }
 
@@ -49,7 +49,7 @@ public function testXliff(string $locale): void
      */
     public static function provideXliffCases(): iterable
     {
-        $files = glob(sprintf('%s/*.xlf', __DIR__.'/../../src/Resources/translations'));
+        $files = glob(\sprintf('%s/*.xlf', __DIR__.'/../../src/Resources/translations'));
 
         if (false === $files) {
             return;
@@ -69,7 +69,7 @@ private function validateXliff(string $file): void
 
             self::assertGreaterThan(0, $catalogue->getResources());
         } catch (InvalidResourceException $e) {
-            $this->errors[] = sprintf('%s => %s', $locale, $e->getMessage());
+            $this->errors[] = \sprintf('%s => %s', $locale, $e->getMessage());
         }
     }
 }

tests/Routing/RoutingTest.php

@@ -37,7 +37,7 @@ public function testLoadRouting(string $routeName, string $path, array $methods)
         $collection->addCollection($subCollection);
 
         $route = $collection->get($routeName);
-        self::assertNotNull($route, sprintf('The route "%s" should exists', $routeName));
+        self::assertNotNull($route, \sprintf('The route "%s" should exists', $routeName));
         self::assertSame($path, $route->getPath());
         self::assertSame($methods, $route->getMethods());
     }

vendor-bin/tools/composer.json

@@ -13,10 +13,7 @@
         "phpstan/phpstan-strict-rules": "^1.5.1",
         "phpstan/phpstan-symfony": "^1.3.1",
         "phpunit/phpunit": "^10.1.2",
-        "psalm/plugin-phpunit": "^0.19.0",
-        "psalm/plugin-symfony": "^5.0.3",
-        "symfony/phpunit-bridge": "^7.0",
-        "vimeo/psalm": "^5.9"
+        "symfony/phpunit-bridge": "^7.0"
     },
     "config": {
         "allow-plugins": {