You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having Awesomplete instance available in events as this.awesompelete will handy.
Discussed here #16821 (comment)
// in all event handlers:varme=this.awesomplete;me.ul.children[me.index];// selected <li> DOM nodeme.suggestions[me.index];// selected suggestion item// and so on...
How about a WeakMap on Awesomplete? Then to get the instance you'd do something like Awesomplete.inputs.get(element). Then we don't need to add properties to elements, which many people have a knee jerk reaction against.
Also, if we do end up making Bliss a dependency, we can add it to element._.
As long as it's not used internally, people can always choose whether they want to use it or not and take the reduced browser support (or include a polyfill).
I’m not against having auxillary features with different browser support if it's clearly indicated in the docs.
We would, however, need to check for it before using it, to avoid breakage in environments where it's not supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having Awesomplete instance available in events as
this.awesompeletewill handy.Discussed here #16821 (comment)