container function to generate container element - #17142
Closed
melitele wants to merge 1 commit into
Closed
Conversation
addresses a use case where container element cannot reuse input element parent because input parent clips container content also solves nudeui#17086
Contributor
Author
|
I just noticed a bug - I'll fix it and resubmit the PR. My apologies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a
containerfunction to options that will allow client to provide a different container element. The default version ofcontainerfunction creates container element as before. I believe this is in line with theitemfunction that customizes creating item elements.This addresses my use case where container element cannot reuse the input element parent
because the input parent clips container's content. It also addresses a case when input element has to be next to it's original siblings.
It also solves #17086 & #16718
Thank you for consideration.