Skip to content

Add ignore diacritics capabilities - #17236

Open
scoopandrun wants to merge 2 commits into
nudeui:gh-pagesfrom
scoopandrun:no-diacritics
Open

Add ignore diacritics capabilities #17236
scoopandrun wants to merge 2 commits into
nudeui:gh-pagesfrom
scoopandrun:no-diacritics

Conversation

@scoopandrun

@scoopandrun scoopandrun commented Apr 26, 2021

Copy link
Copy Markdown

Description

Added the possibility to ignore characters with diacritics.
When the user inputs a string, it should match with the items in the list whether or not the input or the items have accented characters.

Fixes #17187
Fixes #17234

Type of changes

  • New feature (non-breaking change that adds functionality)

This PR introduces a new option Awesomplete.ignoreDiacritics (boolean, default true).
When set to true, it allows matching accented characters against non-accented characters.
When set to false, it requires characters to be the same to match.

This is an implementation of David Calhoun's blog post.

@scoopandrun
scoopandrun marked this pull request as ready for review April 26, 2021 09:27
@LeaVerou

LeaVerou commented Apr 26, 2021

Copy link
Copy Markdown
Collaborator

Hi there,

Thank you for working on this.
I think this should be a usage example, not part of the API surface. Hopefully the existing parameters allow for implementing this that way.

Later down the line we should have plugins, and this could be a plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show list of accented words without having to put the accent Highlighting word with accent

2 participants