Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CI with GitHub actions for publishing #428

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

justinhoward
Copy link
Member

@justinhoward justinhoward commented Jan 23, 2024

Testing to see what needs to be in place to prepare for automated publishing to rubygems. I assume we'll want tests to pass, so some changes or filtering may need to be done to the test suite.

@justinhoward justinhoward force-pushed the prepare-for-ci-publishing branch from 846aa8d to a604002 Compare January 23, 2024 01:43
strategy:
fail-fast: false
matrix:
ruby:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 3.3 be included?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@kangkyu
Copy link
Contributor

kangkyu commented Mar 4, 2025

@justinhoward If not for checking tests passing, and for solely gem release, why don't you remove the test steps from the action?

@justinhoward justinhoward force-pushed the prepare-for-ci-publishing branch from 288d2ef to 6abfa51 Compare March 5, 2025 16:00
@justinhoward justinhoward force-pushed the prepare-for-ci-publishing branch from 6abfa51 to db1ea97 Compare March 5, 2025 16:01
@justinhoward justinhoward marked this pull request as ready for review March 5, 2025 16:03
@justinhoward justinhoward requested a review from kangkyu March 5, 2025 16:03
@justinhoward
Copy link
Member Author

Disabled tests in CI for now. I'm not sure how to solve the testing problem, but perhaps its best to move forward with releases anyway.

@kangkyu kangkyu self-requested a review March 5, 2025 23:21
@justinhoward justinhoward merged commit 83ce3b8 into master Mar 6, 2025
3 checks passed
@justinhoward justinhoward deleted the prepare-for-ci-publishing branch March 6, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants