Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add win-64 wheel builder GHA workflow #1139

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

swap357
Copy link
Contributor

@swap357 swap357 commented Jan 30, 2025

This PR adds a new GitHub Actions workflow for building llvmlite wheels on Windows. Key features:

  • Builds wheels for Python 3.10-3.13 on Windows x64
  • Includes DLL validation
  • Artifacts retention: 7 days

@esc esc mentioned this pull request Feb 3, 2025
@esc esc marked this pull request as ready for review February 6, 2025 14:04
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review, just pointing out initial finds and questions.

.github/workflows/llvmlite_win-64_wheel_builder.yml Outdated Show resolved Hide resolved
.github/workflows/llvmlite_win-64_wheel_builder.yml Outdated Show resolved Hide resolved
.github/workflows/llvmlite_win-64_wheel_builder.yml Outdated Show resolved Hide resolved
.github/workflows/llvmlite_win-64_wheel_builder.yml Outdated Show resolved Hide resolved
@esc
Copy link
Member

esc commented Feb 10, 2025

I modified this to address some of the comments I made. It seems to execute OK. https://github.com/numba/llvmlite/actions/runs/13244880829/workflow

@esc esc force-pushed the llvmlite_win_whl_builder_gha branch from 89a05c7 to b33d8b8 Compare February 10, 2025 17:06
As title
@esc esc requested review from dbast and sklam February 11, 2025 09:06
@dbast dbast force-pushed the llvmlite_win_whl_builder_gha branch from c7a13fc to 5a55be2 Compare February 11, 2025 14:00
dbast
dbast previously approved these changes Feb 11, 2025
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving the changes made by @dbast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants