-
Notifications
You must be signed in to change notification settings - Fork 337
gha/add llvmlite osx 64 conda builder #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha/add llvmlite osx 64 conda builder #1190
Conversation
Co-authored-by: Emergency Self-Construct <[email protected]>
… on recipe to point downloaded recipe
I am testing the https://github.com/esc/llvmlite/actions/runs/14333921715 however, it seems there is an issue trying to download the artifact:
sadly I don't know what the issue is here. Could it be that I need to have run the |
Tried a build of llvmdev on https://github.com/esc/llvmlite/actions/runs/14334012418 The used the workflow ID |
@swap357 thank you for the pushes, I will re-review this now. |
Testing protocol and results: a) merged this PR to esc/llvmlite@main: esc@0b15a08 b) used a GHA produced llvmdev from https://github.com/esc/llvmlite/actions/runs/14334012418 c) ran: https://github.com/esc/llvmlite/actions/runs/14354807935 This was green. The code in this PR is fine. But it can not yet be merged until the following PRs are also green: and the PR for numba osx-64 wheels that has ye to appear. As a result I will label this as "waiting on CI". |
#1187 has been merged. It looks like numba/numba#10023 is also working, and I don't know if we need to wait for the numba osx-64 wheel PR to be created before this one is. I'm going to keep this all moving forward, and if we need to open some smaller PRs to fix up issues found later, we can do that. |
esc's requested change has been made, but he's not available this week to update his review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes @esc requested seem to have been made. Approving.
numba wheel builder PR has been created and tested here - numba/numba#10038 |
this PR adds osx64 conda builder workflow for llvmlite.
It needs same fixes for osx-64 as llvmdev workflow PR - https://github.com/numba/llvmlite/pull/1167/files
This PR is a superset of #1167