Load TOML shells with numtide/devshell #78
+290
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
reviewed
Feb 19, 2025
| ); | ||
|
|
||
| defaultNix = ( | ||
| optionalPathAttrs (src + "/devshell.nix") ( |
There was a problem hiding this comment.
Can you think of any way for blueprint to detect if the devshell.nix is a numtide/devshell module? Otherwise it could be confusing to the user to have the TOML in one system, and the other one in another one.
The new template exercises some features: - TOML devshells are loaded automatically if found. - Nix shells behaviour is preserved: Users are expected to call `mkShell` themselves. Added some documentation explaining why users should call `mkShell` at `devshells/hello.nix` - TOML devshells (and also Nix devshells) can import modules. The template flake also has a couple of checks, ensuring that the devshell commands are correctly provided.
vic
force-pushed
the
load-toml-devshells
branch
from
795f879 to
aa0ae9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset loads TOML devshells using
numtide/blueprint.The only requirement is that the user's flake has an
input.devshellotherwise they will be told to add it.I still have to add documentation for this feature.
Basically, if you have any
/devshells/*.tomlor/devshell.tomlthey will be loaded with something likedevshell.fromTOMLbut that allows custom nix modules to also access packages fromperSystem.self.I'm using this branch at my local nixos setup, see https://github.com/vic/vix/tree/main/devshells for some devshells I've defined, particularly
nixos.tomlthat importsnixos/leader.nixwhich can access packages defined in the flake itself.The old behaviour is still preserved, and any
.nixfiles will still be loaded as-is. So those nix files are responsible for using either nixpkgs's mkShell or devshell's one. For example, myscala3.nixcustomizes the JRE for some tools.I'll be adding documentation tomorrow, and would love if you could direct me on how to write tests for this functionality.
Cheers :)