fix: resolve symlinks in tree root #572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like |
jacobkoziej
force-pushed
the
fix/resolve-symlinks-in-tree-root
branch
from
6355cea to
e092662
Compare
jfly
reviewed
Apr 13, 2025
There was a problem hiding this comment.
Thanks, @jacobkoziej!
I think the reasonable course of action is to re-write the test so that temporary directories that exist on disk get used.
That sounds reasonable to me. See this test for an example of how to create a temp dir for a test:
Line 422 in 9399cd6
We should also make sure the user experience is OK when a non-existent directory is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following resolves symlinks in the tree root path to avoid false-positives where paths (with symlinks) specified inside the tree root are marked outside.