-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: encoder #7
Open
william-silversmith
wants to merge
21
commits into
nurpax:main
Choose a base branch
from
william-silversmith:wms_encode_png
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: encoder #7
william-silversmith
wants to merge
21
commits into
nurpax:main
from
william-silversmith:wms_encode_png
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an spng encoder to the library and builds off of its sister PR #6 for improving the build process.
The encoder currently supports regular, progressive, and interlaced modes as well as a compression level setting. No support for palettes or optimization at this time.
This also fixes an issue where spng was not able to decode GRAY+ALPHA colorspaces (see randy408/libspng#207) because the author of this library was so careful as to specify fmt. I replaced the spng calls with
SPNG_FMT_PNG
to enable that decoding.The tests were updated to include synthetic encoding tests for correctness and benchmark performance. Here are my results on a Macbook Pro M1:
I might add a couple more commits tomorrow. Thanks for reading and for developing a great library!