Open
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
Update the comment in Main.java to correctly refer to the class as Devon instead of Duke. The previous comment referred to Duke, which could lead to confusion when reading the code. Changing this ensures that the codebase accurately reflects the current state of the project. No other functionality is affected by this change, as it is purely a documentation update.
Added assertions in deadlineAction and eventAction to verify non-null command parsing before proceeding with operations. These assertions improve error handling and document important invariants, enhancing code reliability and readability.
Added assertions in deadlineAction and eventAction to verify non-null command parsing before proceeding with operations. These assertions improve error handling and document important invariants, enhancing code reliability and readability.
Add Assertions to Document Key Assumptions in the Devon Bot
Improve Code Quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devon
Devon, your personalized assistant, has been updated to enhance user experience with new features 🔥. Here's what has changed:
Steps to use the updated version:
Features:
If you are a Java programmer, you can use it to practice Java too. Here's the
mainmethod: