Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear selection when exiting visual mode #878

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomasschafer
Copy link

After exiting visual mode with Escape, the selection is currently not cleared until another action is performed such as moving the cursor left or right. This PR fixes that, clearing the selection as soon as Escape is pressed to match the behaviour of Vim.

@132ikl
Copy link

132ikl commented Feb 10, 2025

mentioned this in the Discord, but wanted to add it here also that #867 also implements this, so assuming we get that merged in a timely fashion we can close this PR in favor of #867. otherwise, we can merge this before next Nushell release.

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah making that part of the Esc handler itself is elegant. Should also transfer to the emacs style bindings.

If you want to revisit that part of #867 feel free to update the changes from it, otherwise this is closed by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants