Fix parsing of command #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to allow line breaks between command arguments only when the command is a subexpression
|
nice work! we appreciate all your efforts here. |
|
nice 👌 after updating, it looks much better 🙏 |
|
@amtoine isn't that controlled by highlights.scm? I'm not positive but I thought it was. |
it might not be related to that PR yeah, because it's there in other places, i.e. i did update both the parser and the query file 😉 |
|
what i'm suggesting is that the highlights.scm file is very old and it probably needs a good updating too. |
mrdgo
pushed a commit
to mrdgo/tree-sitter-nu
that referenced
this pull request
Sep 23, 2024
Fix parsing of command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45 , Fix #47
Under the current rule for parsing of command, whether the command is a subexpression or not, line breaks are allowed between command arguments.
This causes the parser to fail to correctly detect the end of a command or pipeline.
This pr changes the rules to allow line breaks between command arguments only when the command is a subexpression.
After this change, the highlights looks like follows
