Skip to content

Fix Connected toast, logged in state #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fix Connected toast, logged in state #183

merged 3 commits into from
Sep 27, 2024
+24 −16

Conversation

@gbakeman
Copy link
Contributor

@gbakeman gbakeman commented Aug 23, 2024 •
edited
Loading

  • Logging code added to the toast/notifyicon trigger code for troubleshooting
  • Moved initial and only Login() call back into the UPS class to remove control logic out of the main WinNUT form and prevent exceptions from being thrown inside an event handler
    • This caused toast notify code to not be called, thus no Connected toast popup.
  • Properly unset logged in flag when disconnecting

Closes

Related to

@gbakeman
Move changestatus method
f904ba4 
Relocating the Event_ChangeStatus method to be closer to other NotifyIcon-related code.
@gbakeman
Restructured toast/balloontip code
ca65848 
- Sub made private, unshared and removed static references to instance members
- Added logging for troubleshooting
@gbakeman gbakeman added bug Something isn't working enhancement New feature or request labels Aug 23, 2024
@gbakeman gbakeman added this to the 2.3 Stable Release milestone Aug 23, 2024
@gbakeman
Fix logged in state, logging in logic
eb6bfc6 
- Relocated the Login() call back into the UPS class to keep logic and exceptions out of the WinNUT form (fixes connected notifications not appearing on reconnect)
- Properly unset logged in flag when disconnecting. From my limited testing, the NUT server does not care how you disconnect from it - you'll always be able to log back in.
@gbakeman gbakeman changed the title Fix Connected Toast not appearing in certain situations Fix Connected toast, logged in state Sep 26, 2024
@gbakeman gbakeman merged commit 7959f5e into dev-2.3 Sep 27, 2024
1 check passed
@gbakeman gbakeman deleted the fix-toasts branch September 27, 2024 17:45
@gbakeman gbakeman linked an issue Nov 2, 2025 that may be closed by this pull request
Connected pop up not appearing after reconnecting in some situations #182
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

2.3 Stable Release

Development

Successfully merging this pull request may close these issues.

Connected pop up not appearing after reconnecting in some situations

2 participants

@gbakeman