Skip to content

Conversation

@SebastianOehm
Copy link
Contributor

…sed as a shutdown condition. Making sure when runtime is not available shutdown will not start immediately regardless of specified percentage

See: #195

…sed as a shutdown condition. Making sure when runtime is not available shutdown will not start immediately regardless of specified percentage

See: nutdotnet#195
@gbakeman
Copy link
Contributor

Thanks for jumping on this PR. Since we're here, I wonder if we need to account for the case where Batt_Charge (percentage) is not provided but Batt_Runtime is. In that case, I think a slightly larger change might make more sense to account for both scenarios (and the third where neither are available.) Let me try and propose something.

@SebastianOehm
Copy link
Contributor Author

Thanks for jumping on this PR. Since we're here, I wonder if we need to account for the case where Batt_Charge (percentage) is not provided but Batt_Runtime is. In that case, I think a slightly larger change might make more sense to account for both scenarios (and the third where neither are available.) Let me try and propose something.

I sincerely doubt this will happen, but let me remedy this really quick

Copy link
Contributor

@gbakeman gbakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always say that to myself, then someone finds a new edgecase 😅

… its value is -1 (indicating its unavailable).
@gbakeman
Copy link
Contributor

Thanks again for the work. Give me a few days to prepare then I'll try to get a Pre-Release out.

@SebastianOehm
Copy link
Contributor Author

I have tested it locally too and it behaved as expected.

@SebastianOehm
Copy link
Contributor Author

Thanks again for the work. Give me a few days to prepare then I'll try to get a Pre-Release out.

That would be amazing, then my system would finally work as intended!

Anyway, nice working with ya, have a good rest of day!

@gbakeman gbakeman merged commit 242078f into nutdotnet:dev-2.3 Oct 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants