-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove oxc-parser
manual wasm fallback logic
#3413
base: main
Are you sure you want to change the base?
perf: remove oxc-parser
manual wasm fallback logic
#3413
Conversation
commit: |
ff094c8
to
033e949
Compare
24308fb
to
0e97bd8
Compare
oxc-parser
manual wasm fallback logic
Based on https://stackblitz.com/edit/oxc-parser I was hoping to remove our manual wasm fallback for However, having this as prod dep will cause issues when installing in unsupported environments (as was the case in this PR). Here some stackblitz reproductions using the preview release of this PR (nuxt-i18n +
I suppose in the case for nuxt-i18n we could add the binding to the stackblitz playground/issue starters, but it would be great to have this working without adding the dependency or at least conditionally if the environment supports it. |
We are currently working with stackblitz to get |
0e97bd8
to
8970ead
Compare
Hi folks! With the latest oxc-parser 0.62.0, it fallbacks to wasm package automatically on stackblitz. Here is a quick example https://stackblitz.com/edit/stackblitz-starters-mv7ri8rj?file=index.js As you can see in the example, currently this adds a few seconds of download time during import (not during |
Experimenting