fix: fix Dockerfile to accept conda tos#134
Conversation
| bash ~/miniconda3/miniconda.sh -b -u -p ~/miniconda3 && \ | ||
| rm ~/miniconda3/miniconda.sh && \ | ||
| source ~/miniconda3/bin/activate && \ | ||
| conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/main && \ |
There was a problem hiding this comment.
@mharrim-nv any concerns hardcoding accepting the terms of service for Conda in our dockerfile?
There was a problem hiding this comment.
Can we add a build arg that the user needs to specify explicitly during docker build otherwise make it fail ( --build_arg ACCEPT_CONDA_TOC=Yes )
There was a problem hiding this comment.
Vaibhav, let's move these two lines to the INSTALL.md instructions instead.
There was a problem hiding this comment.
Specifically here https://github.com/nvidia-cosmos/cosmos-predict1/blob/main/INSTALL.md
Before "You can test the environment setup for inference with":
After launching docker, make sure to accept conda's terms of service by running
conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/main && \
conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/r
or something to that effect.
| bash ~/miniconda3/miniconda.sh -b -u -p ~/miniconda3 && \ | ||
| rm ~/miniconda3/miniconda.sh && \ | ||
| source ~/miniconda3/bin/activate && \ | ||
| conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/main && \ |
There was a problem hiding this comment.
Can we add a build arg that the user needs to specify explicitly during docker build otherwise make it fail ( --build_arg ACCEPT_CONDA_TOC=Yes )
Thought about this some more. A build arg is only good if the user is building the container themselves. It won't work if we offer a ready-made docker on nvcr. How about this solution? #134 (comment) |
|
@pjannaty @codeJRV if we do not accept the conda tos in Dockerfile, the Docker image creation does not proceed. So we will need to build that into the Dockerfile, or we simply do away with conda for docker env. That change will have larger impact, because it will involve modifying the ci-cd pipelines as well. |
No description provided.