Skip to content

fix: fix Dockerfile to accept conda tos#134

Open
rvaibhav wants to merge 2 commits into
nvidia-cosmos:mainfrom
rvaibhav:fix_conda_tos
Open

fix: fix Dockerfile to accept conda tos#134
rvaibhav wants to merge 2 commits into
nvidia-cosmos:mainfrom
rvaibhav:fix_conda_tos

Conversation

@rvaibhav

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Dockerfile
bash ~/miniconda3/miniconda.sh -b -u -p ~/miniconda3 && \
rm ~/miniconda3/miniconda.sh && \
source ~/miniconda3/bin/activate && \
conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/main && \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mharrim-nv any concerns hardcoding accepting the terms of service for Conda in our dockerfile?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a build arg that the user needs to specify explicitly during docker build otherwise make it fail ( --build_arg ACCEPT_CONDA_TOC=Yes )

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vaibhav, let's move these two lines to the INSTALL.md instructions instead.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically here https://github.com/nvidia-cosmos/cosmos-predict1/blob/main/INSTALL.md

Before "You can test the environment setup for inference with":
After launching docker, make sure to accept conda's terms of service by running

conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/main && \
conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/r

or something to that effect.

@codeJRV codeJRV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvaibhav can you take a look at the suggestion to add a build arg to accept TOS

Comment thread Dockerfile
bash ~/miniconda3/miniconda.sh -b -u -p ~/miniconda3 && \
rm ~/miniconda3/miniconda.sh && \
source ~/miniconda3/bin/activate && \
conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/main && \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a build arg that the user needs to specify explicitly during docker build otherwise make it fail ( --build_arg ACCEPT_CONDA_TOC=Yes )

@pjannaty

Copy link
Copy Markdown
Contributor

@rvaibhav can you take a look at the suggestion to add a build arg to accept TOS

Thought about this some more. A build arg is only good if the user is building the container themselves. It won't work if we offer a ready-made docker on nvcr. How about this solution? #134 (comment)

@rvaibhav

rvaibhav commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

@pjannaty @codeJRV if we do not accept the conda tos in Dockerfile, the Docker image creation does not proceed.

So we will need to build that into the Dockerfile, or we simply do away with conda for docker env. That change will have larger impact, because it will involve modifying the ci-cd pipelines as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants