feat: improved lsp setup for nvim > 0.11 #1590
Open
+90
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oriori1703
suggested changes
Jun 7, 2025
There was a problem hiding this comment.
I quite like the idea of teaching how to use servers that were not installed by mason, so I think I prefer this over #1475 (even though it is also great :)
Though I think the formatting changes should be left out of this PR.
Also, I left a couple of suggestions for minor improvements.
Add lua_ls annotations for improved hover experience and replace vim.fn.empty() with vim.tbl_isempty()
umutondersu
added a commit
to umutondersu/nvim
that referenced
this pull request
Jun 12, 2025
umutondersu
added a commit
to umutondersu/nvim
that referenced
this pull request
Jun 12, 2025
jonasmalacofilho
added a commit
to jonasmalacofilho/dotfiles
that referenced
this pull request
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this change is to provide a much clearer distinction between how servers are installed & configured (either directly via Mason or manually). This is a slight alternative to this excellent PR for LSP configuration for neovim > 0.11 onwards.
Since the new
mason-lspconfigchanges enable all servers installed via Mason by default, this might cause confusion for newcomers around server enable if they had a language server installed manually but wanted to re-use the defaultnvim-lspconfigconfigs.Furthermore, not all language servers might be available on Mason for download - however they might already have default configs available on
nvim-lspconfigfor re-use (example) or have neither available on Mason andnvim-lspconfig.I'm hoping another benefit of this change is that it should also aid in reducing burden on the mason & nvim-lspconfig maintainers when it comes to answering these specific kind of lsp questions.
As always, I'm open to any feedback here. I'm not too fussed if the above linked PR gets merged over this, but wanted to float this idea by the maintainers and community to gather any & all feedback.
Cheers! 🙂
Minor Changes: