fix: update mason-lspconfig setup to not use deprecated handlers #1619
+10
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @moguls753 |
|
Hey @guru245, I totally missed #1475—thanks for pointing it out! That PR switches over to the new Neovim ≥0.11 LSP API, while this one sticks with the classic require('lspconfig').<server>.setup{…}Given that many distros (for example, Ubuntu 25 LTS ships 0.9.5) still ship older Neovims, I think it makes sense to keep using the legacy API, which isn’t going away anytime soon. For me #1475 is working perfectly fine though. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
handlerssetting is removed in mason-lspconfig v2.0, I think the following makes sense.Remove deprecated
handlersAPI andautomatic_installationSet
automatic_enable = falsesince setup() is invoked explicitly