Skip to content

Replace rootpath with rootdir #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace rootpath with rootdir #106

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5aa313f
Replace rootdir with rootpath
vandalt May 29, 2025
2d8b739
Add try/except to handle older pytest versions as well
vandalt Oct 12, 2025
5abe6f1
Extract try/except to a function and use in `pytest_runtest_makereport`
vandalt Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions neotest_python/pytest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,19 @@ def _get_short_output(
buffer.seek(0)
return buffer.read()

def _get_abs_path(self, file_path: Union[str, Path]):
try:
# rootpath is now the preferred way to access root
abs_path = str(self.pytest_config.rootpath / file_path)
except AttributeError:
# fallback to rootdir for older pytest versions
abs_path = str(Path(self.pytest_config.rootdir, file_path))
return abs_path

def pytest_deselected(self, items: List["pytest.Item"]):
for report in items:
file_path, *name_path = report.nodeid.split("::")
abs_path = str(Path(self.pytest_config.rootdir, file_path))
abs_path = self._get_abs_path(file_path)
*namespaces, test_name = name_path
valid_test_name, *params = test_name.split("[") # ]
pos_id = "::".join([abs_path, *(namespaces), valid_test_name])
Expand Down Expand Up @@ -108,7 +117,7 @@ def pytest_runtest_makereport(
return

file_path, *name_path = item.nodeid.split("::")
abs_path = str(Path(self.pytest_config.rootdir, file_path))
abs_path = self._get_abs_path(file_path)
*namespaces, test_name = name_path
valid_test_name, *params = test_name.split("[") # ]
pos_id = "::".join([abs_path, *namespaces, valid_test_name])
Expand Down