Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission for team 1 #1

Closed
wants to merge 44 commits into from
Closed

Submission for team 1 #1

wants to merge 44 commits into from

Conversation

Frankbz
Copy link

@Frankbz Frankbz commented Sep 30, 2024

No description provided.

Nightshade14 and others added 30 commits September 11, 2024 20:36
@Nightshade14
Initial commit
c2d4b69
@Nightshade14
Update README.md
6dc18e7
@Nightshade14
feat: Set-up initial repository
62cef54
@Nightshade14
feat: Add tests and make code Ruff compliant
cabbe18 
Make Ruff ignore the assert linting. Assert is useful when used with pytest for detailed test messages.
@Nightshade14
feat: Add circleCI config file to test circleci workflow
9488f2c 
The config file spins up a python 3.12.6 image and prints python version
@Nightshade14
Merge pull request nyuoss#1 from Nightshade14/dev
f84b405 
feat: Add circleCI config file to test circleci workflow
@Nightshade14
feat: Test circleci demo-1
2143ec7
@Nightshade14
fix: Update the config.yml file to remove syntax errors
8f3bb70
@Nightshade14
fix: Update the python version
c4b97aa
@Nightshade14
feat: Add whole build, lint, format and test workflow
75f5f96
@Nightshade14
debug: Print all the dir after cloning the repo in the docker container
6f52150
@Nightshade14
debug: Check the pwd of the new run
75218f5
@Nightshade14
debug: Restart shell for uv installation to take place
a5d7de7 
Without it, the uv command was not recognized
@Nightshade14
debug: Add explicit command to reload bash
d962a14
@Nightshade14
debug: Add command to set uv path to bash envs
42f99ae
@Nightshade14
debug: Print files and directories at the error point
e70c159
@Nightshade14
debug: Shift the uv sync command onto uv installation stage
867973c
@Nightshade14
fix: Move all jobs within a single job
c1736d1
@Nightshade14
fix: Shift multiple jobs to a single job, remove dummy.py, update lin…
1d1b69a 
…ting rules
@Nightshade14
feat: Test circleci demo-1
19cca88
@Nightshade14
fix: Update the config.yml file to remove syntax errors
9876d53
@Nightshade14
fix: Update the python version
354d65f
@Nightshade14
feat: Add whole build, lint, format and test workflow
2e5d21e
@Nightshade14
debug: Print all the dir after cloning the repo in the docker container
f3b1e1b
@Nightshade14
debug: Check the pwd of the new run
a20a5e5
@Nightshade14
debug: Restart shell for uv installation to take place
610f6dd 
Without it, the uv command was not recognized
@Nightshade14
debug: Add explicit command to reload bash
d4f14b9
@Nightshade14
debug: Add command to set uv path to bash envs
320734f
@Nightshade14
debug: Print files and directories at the error point
91e4acb
@Nightshade14
debug: Shift the uv sync command onto uv installation stage
3d1b8a6
Nightshade14 and others added 14 commits September 14, 2024 20:11
@Nightshade14
fix: Move all jobs within a single job
c88c0cd
@Nightshade14
fix: Shift multiple jobs to a single job, remove dummy.py, update lin…
29b0269 
…ting rules
docs: Update README.md
17351f8
update: Update the .gitignore
5ea904d
@Nightshade14
Merge pull request nyuoss#5 from Nightshade14/dev
b206f83 
Dev
docs: Update the README.md file with project instructions and setup
addbfb9
@Nightshade14
Merge pull request nyuoss#6 from Nightshade14/dev
38a2413 
docs: Update the README.md file with project instructions and setup
@Nightshade14
docs: Update the README.md
8857a61 
Add License info to readme file as well.
@Nightshade14
Merge pull request nyuoss#7 from Nightshade14/dev
f8b0687 
docs: Update the README.md
@Nightshade14
docs: Update README.md file
6c1ad55 
Added new instructions about actively participating in the project and some more deatils about project standards (technical and non-technical).
@Nightshade14
Merge pull request nyuoss#8 from Nightshade14/dev
6f768ea 
docs: Update README.md file
@Nightshade14
docs: Update README.mdd file
f7118cc 
Added the information of the CircleCI project that is used with this project (magic2).
@Nightshade14
Merge pull request nyuoss#10 from Nightshade14/dev
14ea0b2 
docs: Update README.mdd file
@Frankbz
Merge remote-tracking branch 'original-project/main' into submission
e91406b
@kyotov
Copy link
Collaborator

kyotov commented Oct 6, 2024

this is not easy to review
there are many commits and there is no common history with the repo.
squash all the commits and rebase on top of the master branch in the repo so the request is reviewable.
checkout the other pull request from the other team to see.

@Frankbz
Copy link
Author

Frankbz commented Oct 8, 2024

New submission is at: #3

@Frankbz Frankbz closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frankbz @kyotov @Nightshade14