Python 3.9 compatibility #735
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
|
@vinzenz add please description in the commit msg. basically the PR description seems good. Plus adding the link (https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods) for people who want to read more details could be nice bonus, but not necessary. |
|
@vinzenz I think it's good time to revive this one :) |
|
@vinzenz rebase please. |
|
Hmm I thought I did rebase it back in January, but obviously I didn't - I just rebased it @pirat89 |
|
/rerun |
|
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3599638 |
|
Testing Farm request for 7to8/3598146,3599638 regression testing has been created. Once finished, results should be available here. |
|
Testing Farm request for 8to9/3598146,3599638 regression testing has been created. Once finished, results should be available here. |
|
/rerun |
|
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3600580 |
|
Testing Farm request for 7to8/3598146,3600580 regression testing has been created. Once finished, results should be available here. |
|
Testing Farm request for 8to9/3598146,3600580 regression testing has been created. Once finished, results should be available here. |
There was a problem hiding this comment.
I can't test that unfortunately as I don't have a macos at hand.
But regression tests are fine so if you @vinzenz say it fixes your issue - I'd like to merge it.
|
@fernflower we have confirmation from @vinzenz . merghing. thanks for co-review! I like PRs with 2+ reviews :) |
In Python 3.9 tests fail on macos because multiprocessing does no longer fork, to prevent this behavior from changing at all this PR adds a workaround for this.
Related issue #690