cmd/rofl: Add providers list and show commands#650
Conversation
✅ Deploy Preview for oasisprotocol-cli ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/providers-show
branch
2 times, most recently
from
f55c598 to
4fd9e23
Compare
| cobra.CheckErr(err) | ||
|
|
||
| // Parse provider address. | ||
| providerAddr := args[0] |
There was a problem hiding this comment.
Can you do oasis rofl provider show [<address>] so that it shows you offers for the given provider or the one in the current ROFL manifest (--deployment can be added) or default, if none provided.
There was a problem hiding this comment.
But doesn't the oasis rofl deploy --show-offers already do this? Does it make sense to duplicate this behaviour?
There was a problem hiding this comment.
oasis rofl deploy --show-offers should now be synonym for oasis rofl provider show <the-validator-in-rofl-yaml-or-default-one>, because the new command also shows you a number of other interesting things such as the number of nodes, when was provider registered etc. This can be done in a separate PR though.
There was a problem hiding this comment.
Updated,oasis rofl deploy --show-offers now reuses code from rofl/provder/...
ptrus
force-pushed
the
ptrus/feature/providers-show
branch
from
4fd9e23 to
cbc71f7
Compare
|
Added docs |
ptrus
force-pushed
the
ptrus/feature/providers-show
branch
from
cbc71f7 to
f327daf
Compare
ptrus
force-pushed
the
ptrus/feature/providers-show
branch
2 times, most recently
from
926edaa to
52b806e
Compare
|
Updated |
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
Some suggestions to simplify and unify the outputs. Otherwise looks good to merge IMO!
ptrus
force-pushed
the
ptrus/feature/providers-show
branch
from
52b806e to
5f47524
Compare
ptrus
force-pushed
the
ptrus/feature/providers-show
branch
from
5f47524 to
ac6d03b
Compare
2 participants
Fixes: #648
See examples for added commands.