common: Fix NumericToBigInt returning zero for negative exponents #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/bugfix/numeric-to-big-int
branch
from
5c6820f to
ba6d086
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes two critical bugs: one in NumericToBigInt that caused it to always return zero for negative exponents, and another in the balance update check that used pointer comparison instead of value comparison.
- Fixes
NumericToBigIntto return the calculated value instead of zero when handling negative exponents - Replaces incorrect pointer comparison with proper value comparison in balance update logic
- Adds comprehensive test coverage for
NumericToBigInt
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| common/types.go | Fixed return value from *big0 to *bi in NumericToBigInt for negative exponent path, and simplified error return |
| common/types_test.go | Added comprehensive test suite for NumericToBigInt covering zero, positive, and negative exponents |
| analyzer/runtime/runtime.go | Changed balance comparison from pointer comparison (!= big.NewInt(0)) to value comparison (.Sign() != 0) |
| .changelog/1226.bugfix.md | Documents the pointer comparison fix in analyzer/runtime |
| .changelog/1226.bugfix.2.md | Documents the NumericToBigInt fix in common package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.