Fix charged fee for oasis encoded eth txs #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/fix/consensus-events-type
branch
2 times, most recently
from
1051778 to
7dc5144
Compare
ptrus
force-pushed
the
ptrus/fix/consensus-events-type
branch
from
7dc5144 to
b8bfdf2
Compare
There was a problem hiding this comment.
Pull request overview
This pull request fixes two bugs in SQL queries: one affecting how charged fees are calculated for Oasis-encoded Ethereum transactions, and another fixing an edge case in consensus event queries.
Changes:
- Updated charged fee calculation to properly handle Oasis-encoded EVM transactions by checking method names
- Fixed JOIN condition for events_related_accounts to include event type, preventing incorrect event matches
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| storage/client/queries/queries.go | Fixed charged_fee calculation to include EVM methods check and added type field to events_related_accounts JOIN |
| .changelog/1234.bugfix.1.md | Documents the charged fee fix for Oasis-encoded ETH transactions |
| .changelog/1234.bugfix.2.md | Documents the consensus events JOIN fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.