Skip to content

Conversation

@martintomazic
Copy link
Contributor

@martintomazic martintomazic commented Jul 23, 2025

As discussed in #6262 it might be simpler to manually handle fallback to the legacy protocol.

Closes #5751.

Regarding the style, I would prefer to keep it consistent with other p2p packages even if not optimal: #6262 (comment)

@netlify
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit c02ca0c
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/6894684407829200088ade23

@martintomazic martintomazic force-pushed the martin/feature/split-storagesync-p2p-v2 branch 3 times, most recently from 7461171 to a234758 Compare July 24, 2025 10:57
@martintomazic martintomazic force-pushed the martin/feature/split-storagesync-p2p-v2 branch from a234758 to 036756f Compare July 24, 2025 11:12
@martintomazic martintomazic marked this pull request as ready for review July 24, 2025 11:30
@martintomazic martintomazic force-pushed the martin/feature/split-storagesync-p2p-v2 branch 2 times, most recently from 8cf69e6 to 6b30fe1 Compare July 30, 2025 20:53
@martintomazic martintomazic requested a review from peternose July 30, 2025 21:05
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 82.47012% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.70%. Comparing base (a81a9dd) to head (c02ca0c).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
go/worker/storage/committee/checkpoint_sync.go 72.88% 16 Missing ⚠️
go/worker/storage/p2p/checkpointsync/server.go 73.68% 6 Missing and 4 partials ⚠️
go/worker/storage/p2p/diffsync/server.go 73.33% 5 Missing and 3 partials ⚠️
go/worker/storage/committee/node.go 80.64% 5 Missing and 1 partial ⚠️
go/worker/storage/p2p/checkpointsync/client.go 95.45% 1 Missing and 1 partial ⚠️
go/worker/storage/p2p/diffsync/client.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6277      +/-   ##
==========================================
+ Coverage   64.62%   64.70%   +0.08%     
==========================================
  Files         690      696       +6     
  Lines       67593    67803     +210     
==========================================
+ Hits        43680    43870     +190     
- Misses      18855    18880      +25     
+ Partials     5058     5053       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martintomazic martintomazic force-pushed the martin/feature/split-storagesync-p2p-v2 branch from 6b30fe1 to 27cfc64 Compare August 5, 2025 08:50
Copy link
Collaborator

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@martintomazic martintomazic force-pushed the martin/feature/split-storagesync-p2p-v2 branch 3 times, most recently from 48d10af to aac7046 Compare August 6, 2025 23:07
@martintomazic martintomazic force-pushed the martin/feature/split-storagesync-p2p-v2 branch from aac7046 to c02ca0c Compare August 7, 2025 08:48
@martintomazic martintomazic merged commit d8d0e69 into master Aug 7, 2025
7 checks passed
@martintomazic martintomazic deleted the martin/feature/split-storagesync-p2p-v2 branch August 7, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate storage checkpoint sync p2p protocol

3 participants