-
Notifications
You must be signed in to change notification settings - Fork 148
Split storage sync P2P protocol (manual fallback) #6277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
7461171 to
a234758
Compare
a234758 to
036756f
Compare
8cf69e6 to
6b30fe1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6277 +/- ##
==========================================
+ Coverage 64.62% 64.70% +0.08%
==========================================
Files 690 696 +6
Lines 67593 67803 +210
==========================================
+ Hits 43680 43870 +190
- Misses 18855 18880 +25
+ Partials 5058 5053 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6b30fe1 to
27cfc64
Compare
peternose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
48d10af to
aac7046
Compare
Legacy storage sync protocol is still advertised and served to enable seamless rolling upgrades of the network.
aac7046 to
c02ca0c
Compare
As discussed in #6262 it might be simpler to manually handle fallback to the legacy protocol.
Closes #5751.
Regarding the style, I would prefer to keep it consistent with other p2p packages even if not optimal: #6262 (comment)