Skip to content

Conversation

@peternose
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 0a57136
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/68b771dd4f0d9e0008d01399

@peternose peternose linked an issue Aug 19, 2025 that may be closed by this pull request
@peternose peternose marked this pull request as ready for review August 19, 2025 21:04
@kostko
Copy link
Member

kostko commented Aug 20, 2025

Can you check that this works as expected when syncing Testnet and Mainnet over some past key manager policy upgrades?

@peternose peternose force-pushed the peternose/breaking/km-policy branch from 9c0d625 to e10342d Compare August 20, 2025 07:19
@peternose
Copy link
Collaborator Author

Can you check that this works as expected when syncing Testnet and Mainnet over some past key manager policy upgrades?

Sure, will test and let you know.

@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.51%. Comparing base (2969de8) to head (0a57136).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../consensus/cometbft/apps/keymanager/secrets/txs.go 70.58% 2 Missing and 3 partials ⚠️
...t/apps/keymanager/secrets/state/interop/interop.go 0.00% 4 Missing ⚠️
go/keymanager/secrets/sanity_check.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6300      +/-   ##
==========================================
- Coverage   65.29%   64.51%   -0.79%     
==========================================
  Files         697      697              
  Lines       67836    67847      +11     
==========================================
- Hits        44294    43770     -524     
- Misses      18595    19089     +494     
- Partials     4947     4988      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peternose
Copy link
Collaborator Author

Can you check that this works as expected when syncing Testnet and Mainnet over some past key manager policy upgrades?

Synced mainnet (polices with serial from 9 to 19) and testnet (policies with serials from 25 to 51 and from 1 to 4).

@peternose peternose force-pushed the peternose/breaking/km-policy branch from e10342d to 0a57136 Compare September 2, 2025 22:38
@peternose peternose merged commit 363ae9e into master Sep 2, 2025
3 of 7 checks passed
@peternose peternose deleted the peternose/breaking/km-policy branch September 2, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only apply new key manager policy at epoch boundary

3 participants