go/worker/storage/committee: Fix prune handler #6445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
Collaborator
|
Looks good and makes sense. |
In case of empty state DB, last synced round is set to max uint64 value, thus the worker prunes light history even if it should not do it.
martintomazic
force-pushed
the
martin/fix/storage-committee-prune-handler
branch
from
c446561 to
be877f2
Compare
peternose
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this bug ever since, just nobody noticed.
If you set runtime with pruning and genesis sync, first thing will be the runtime light history created by indexing consensus data. Light history is needed to fetch corresponding runtime state. To prevent too early pruning of light history, prune handlers don't allow to prune it past last synced round.
Unfortunately, if the runtime state DB is empty,
worker.GetLastSynced()returnsdefaultUndefinedRoundthat equals to maxuint64, effectively allowing to prune anything. This removes early light history, and the node is then later (once consensus is synced) stuck at checkpoint sync, as there is no corresponding light block to verify the genesis checkpoint against.Also noticed pruning with default parameters is set to 64 rounds every 2 minutes. With #6355 merged, we might want to bump the defaults...