fix(scope): warn on empty scope segments#70
Merged
Conversation
Flag repeated, leading, or trailing slashes in scope linting by detecting empty path segments. Fixes ob-labs#56.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag repeated, leading, or trailing slashes in scope linting by detecting empty path segments.
Fixes #56.
Summary
Make scope linting report malformed scopes that contain empty path segments, such as
acme//pay.Solution Description
scope.split("/")._lint_scope("acme//pay").Verified with:
uv run ruff check src/ tests/uv run ruff format --check src/ tests/uv run pytest tests/ -q