Skip to content

feat(conducting-code-review): add missing reviewer-side skill#814

Open
HelenGreul wants to merge 1 commit intoobra:mainfrom
HelenGreul:feat/conducting-code-review
Open

feat(conducting-code-review): add missing reviewer-side skill#814
HelenGreul wants to merge 1 commit intoobra:mainfrom
HelenGreul:feat/conducting-code-review

Conversation

@HelenGreul
Copy link

Summary

  • Adds skills/conducting-code-review/SKILL.md — the missing third skill in the review workflow

Problem

The repo has requesting-code-review (how to ask for a review) and receiving-code-review (how to handle feedback), but no skill for conducting a review. The reviewer has no guidance.

This means:

  • Subagents dispatched as reviewers have no skill to trigger
  • Human reviewers using Superpowers get no structured process
  • The requesting-code-review skill dispatches a superpowers:code-reviewer subagent, but there's no matching skill on the reviewer side

What the skill covers

  • 5-step process: Orient → Read diff → Verify → Categorize → Report
  • Separate checklists for code PRs vs prompt/skill PRs (this repo's primary content type)
  • Severity classification with criteria to prevent inflation
  • Explicit forbidden behaviors (vague feedback, missing verdicts)
  • Integration with the subagent-driven-development and GitHub PR workflows
  • References the 3-comment-type fetch from PR fix(receiving-code-review): add guidance to fetch all 3 PR comment types #812

Relationship to existing skills

requesting-code-review  →  conducting-code-review  →  receiving-code-review
    (author)                     (reviewer)                  (author)

🤖 Generated with Claude Code

The workflow had skills for requesting and receiving review, but nothing
for the reviewer conducting the review. This closes the loop.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@obra obra added enhancement New feature or request claude-code Claude Code (Anthropic CLI) issues skills Skill system, development, and individual skills no-obvious-human-review Submission shows no evidence of human review labels Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-code Claude Code (Anthropic CLI) issues enhancement New feature or request no-obvious-human-review Submission shows no evidence of human review skills Skill system, development, and individual skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants