Skip to content

fix(debugging): correct broken Phase 4.5 reference#914

Open
chris-yyau wants to merge 1 commit intoobra:mainfrom
chris-yyau:fix/debugging-phase-reference
Open

fix(debugging): correct broken Phase 4.5 reference#914
chris-yyau wants to merge 1 commit intoobra:mainfrom
chris-yyau:fix/debugging-phase-reference

Conversation

@chris-yyau
Copy link

@chris-yyau chris-yyau commented Mar 24, 2026

What problem are you trying to solve?

The Red Flags section of systematic-debugging/SKILL.md says "see Phase 4.5" but there is no "Phase 4.5" heading in the document. The intended target is Phase 4, Step 5 ("If 3+ Fixes Failed: Question Architecture") at line 199. An agent following this reference would fail to locate the section.

What does this PR change?

Updates the reference from "Phase 4.5" to "Phase 4, Step 5" to match the actual document structure.

Is this change appropriate for the core library?

Yes — this fixes a broken internal reference in a core skill document. The systematic debugging skill is general-purpose infrastructure.

What alternatives did you consider?

  1. Rename the heading to "Phase 4.5" — Rejected because the document uses "Phase N, Step M" structure throughout. Renaming would break that convention.
  2. Remove the cross-reference entirely — Rejected because the reference is useful; the reader needs to know where to find the architectural questioning guidance.

Does this PR contain multiple unrelated changes?

No. Single reference fix.

Existing PRs

  • I have reviewed all open AND closed PRs for duplicates or prior art
  • Related PRs: none found

Environment tested

Harness Harness version Model Model version/ID
Claude Code 1.0.33 Claude claude-opus-4-20250514

Evaluation

  • Initial prompt: "Audit superpowers skill documents for broken cross-references"
  • Verified by searching the document for all "Phase" references and confirming they now resolve to actual headings.
  • Single documentation fix — behavioral eval not applicable.

Rigor

  • If this is a skills change: I used superpowers:writing-skills and completed adversarial pressure testing (paste results below)
  • This change was tested adversarially, not just on the happy path
  • I did not modify carefully-tuned content (Red Flags table, rationalizations, "human partner" language) without extensive evals showing the change is an improvement

This changes a cross-reference string only, not behavior-shaping content.

Human review

  • A human has reviewed the COMPLETE proposed diff before submission

The Red Flags section references "Phase 4.5" which doesn't exist.
The intended target is Phase 4, Step 5 ("If 3+ Fixes Failed: Question
Architecture") at line 199.
Copilot AI review requested due to automatic review settings March 24, 2026 11:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an incorrect internal reference in the systematic debugging skill so the “Red Flags” section points to an existing heading/step in Phase 4.

Changes:

  • Update “see Phase 4.5” to “see Phase 4, Step 5” to match the document’s actual structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants