Feature winners popup#26
Draft
sica42 wants to merge 31 commits into
Draft
Conversation
…ames. Fix RR not being displayed correct
sica42
commented
Feb 24, 2025
|
|
||
| m.map( winners, function( winner ) | ||
| winner_tracker.track( winner.name, item.link, winner.roll_type, winner.roll, strategy ) -- TODO: remove from here and subscribe to the event. | ||
| winner_tracker.track( winner.name, item.link, winner.roll_type, winner.winning_roll, strategy ) -- TODO: remove from here and subscribe to the event. |
Contributor
Author
There was a problem hiding this comment.
I don't use roll value from winner_tracker anymore, but this seems like a bug anyway. winner only has winning_roll and not roll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Think this is pretty much complete now. A couple of notes:
Edit I did the split, so all gui elements are in a separate file now.
local _, current_iteration = roll_tracker.get()will get the correct iteration in case of ties as I've not tested it with any tie results.Edit Have confirmed that tie rolls work correctly.
If I do a rewrite, I could maybe try to integrate it into the FrameBuilder?