Fix bug in unboxing decision code + use max unboxing depth cli flag #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, in this case, CI found a bug with the new implementation of unboxing (this PR triggers it because it makes the default max unboxing depth go from 1 to 3). I think I see what the bug is, I'm working on fixing it. |
Gbury
force-pushed
the
use_max_unboxing_depth
branch
from
b5a0333 to
fbf4b71
Compare
|
This PR now also fixes a bug in the unboxing code, see the commit message. |
Gbury
changed the title
In some cases, a generated poison values for an unboxed arg was later "transformed" into an available simple pointing to the "invalid" constant for the adequate kind. This could bring problem where a constant value is then passed to a deeper decisions that expects a variant with no constant constructors.
Gbury
force-pushed
the
use_max_unboxing_depth
branch
from
d3297bb to
ac252ef
Compare
|
This has been rebased, so it should be good for merging once CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.