Allow concurrent exec with watch mode #11840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridbugs
force-pushed
the
exec-concurrent-with-watch-mode
branch
from
1d6ea1e to
09a0dbe
Compare
|
Thanks for the PR, it'll be easier to review once #11833 is merged. |
gridbugs
changed the title
gridbugs
force-pushed
the
exec-concurrent-with-watch-mode
branch
from
09a0dbe to
63481de
Compare
gridbugs
force-pushed
the
exec-concurrent-with-watch-mode
branch
from
63481de to
d5ef824
Compare
Signed-off-by: Stephen Sherratt <[email protected]>
The only [out_channel] that was ever passed in was stderr. Removing the [Out_channel] case allows us to more easily test [Log.File.t] for equality. Signed-off-by: Stephen Sherratt <[email protected]>
Signed-off-by: Stephen Sherratt <[email protected]>
Signed-off-by: Stephen Sherratt <[email protected]>
This change allows a limited version of `dune exec` to run at the same time as dune is running in watch mode. This allows users to run example programs without needing to stop their watch server. This works by sending messages to the RPC server to build the executable if necessary. Signed-off-by: Stephen Sherratt <[email protected]>
gridbugs
force-pushed
the
exec-concurrent-with-watch-mode
branch
from
d5ef824 to
f3b6fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows a limited version of
dune execto run at the same time as dune is running in watch mode. This allows users to run example programs without needing to stop their watch server. This works by sending messages to the RPC server to build the executable if necessary.