Skip to content

fix(cram): improve and deduplicate test suggestions #12663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(cram): improve and deduplicate test suggestions #12663

wants to merge 3 commits into from
+43 −40

Conversation

@Alizter
Copy link
Collaborator

@Alizter Alizter commented Oct 31, 2025 •
edited
Loading

  • In the first commit we split up listing and finding cram tests.
  • In the second commit we only suggest cram tests when giving hints.
  • In the third commit we deduplicate suggestions that we give.

@Alizter Alizter changed the title refactor: split finding cram tests and collecting cram tests fix(cram): improve and deduplicate test suggestions Oct 31, 2025
@Alizter Alizter requested a review from rgrinberg November 1, 2025 00:48
@rgrinberg
Copy link
Member

How about a test to demonstrate the improved error message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgrinberg rgrinberg Awaiting requested review from rgrinberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alizter @rgrinberg