Skip to content

Update src urls in alt-ergo 0.95.2 to 2.3.3 from http to https #28896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 16, 2025
Merged

Update src urls in alt-ergo 0.95.2 to 2.3.3 from http to https #28896

merged 7 commits into from
Nov 16, 2025

Conversation

@jmid
Copy link
Member

@jmid jmid commented Nov 14, 2025

This PR updates src urls in alt-ergo 0.95.2 to 2.3.3 from http to https to avoid curl failure:

$ curl -i http://alt-ergo.ocamlpro.com/http/alt-ergo-0.95.2/alt-ergo-0.95.2.tar.gz
HTTP/1.1 301 Moved Permanently
Server: nginx/1.18.0 (Ubuntu)
Date: Fri, 14 Nov 2025 16:01:29 GMT
Content-Type: text/html
Content-Length: 178
Connection: keep-alive
Location: https://alt-ergo.ocamlpro.com/http/alt-ergo-0.95.2/alt-ergo-0.95.2.tar.gz

<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx/1.18.0 (Ubuntu)</center>
</body>
</html>

I strongly suspect this is the reason why we are seeing so many tests (failed: Failed to get sources of alt-ergo.1.01: curl failed) on #28841:

#=== ERROR while fetching sources for alt-ergo.1.01 ===========================#
OpamSolution.Fetch_fail("http://alt-ergo.ocamlpro.com/http/alt-ergo-1.01/alt-ergo-1.01.tar.gz (curl failed: \"/usr/bin/curl --write-out %{http_code}\\\\n --retry 3 --retry-delay 2 --user-agent opam/2.5.0~alpha1 -L -o /tmp/opam-7-836f70/alt-ergo-1.01.tar.gz.part -- http://alt-ergo.ocamlpro.com/http/alt-ergo-1.01/alt-ergo-1.01.tar.gz\" exited with code 6)")

@jmid jmid mentioned this pull request Nov 14, 2025
Open
@jmid
Copy link
Member Author

jmid commented Nov 14, 2025

There wasn't much info from the opam-ci log (other than lint errors):
https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/641badb919372059363babf4d29b02c5a3c6e52f

Looking at the Cygwin CI logs
https://github.com/ocaml/opam-repository/actions/runs/19370287811/job/55424139302?pr=28896
I could confirm the updated URLs could be used, but then saw http still being used for related alt-ergo-* packages:

  -> retrieved alt-ergo.2.3.0  (https://alt-ergo.ocamlpro.com/http/alt-ergo-2.3.0/alt-ergo-2.3.0.tar.gz)
  -> retrieved alt-ergo-lib.2.3.0, alt-ergo-parsers.2.3.0  (http://alt-ergo.ocamlpro.com/http/alt-ergo-2.3.0/alt-ergo-2.3.0.tar.gz)

The last 3 commits therefore updates the URLs for those too...

@jmid
Copy link
Member Author

jmid commented Nov 14, 2025

I pushed small field changes to silence the linter.

I've also checked the CI logs from MinGW workflows, where none of the failures are related to changing http to https. They say retrieved alt-ergo-lib.2.3.2, alt-ergo-parsers.2.3.2 (https://alt-ergo.ocamlpro.com/http/alt-ergo-2.3.2/alt-ergo-2.3.2.tar.gz) indicating a correct URL + usage of https.

As such this should be good to go.

@mseri
Copy link
Member

mseri commented Nov 16, 2025 •
edited
Loading

Thanks. Maybe we should start always enforcing https with a ci check?

@mseri mseri merged commit 10e3e45 into ocaml:master Nov 16, 2025
2 of 4 checks passed
@jmid jmid deleted the fix-alt-ergo-http branch November 16, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

consider for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmid @mseri