Hotfixes for labgtk3 for Windows #28918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
|
maybe better to introduce a new version, 3.1.5-1? ref #10531 |
Member
Author
|
Oh, that's an extremely good point - sorry, I get too used to the compiler packages, where we of course sadly can't do that! |
dra27
force-pushed
the
msys2-lablgtk3
branch
from
e6e1d1a to
be3803d
Compare
Member
I don't quite understand what in the compiler packages prevents you from doing that. But I barely understand much about the compiler packages. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSVC part hot-fixes garrigue/lablgtk#190, which I haven't yet fully tested because I'm still reviewing the MSVC patches for cairo2 for opam.
The mingw-w64 part I think is almost certainly a wider GCC-15 related patch needed for all systems, which I haven't yet upstreamed. With this second part, I can build #28851 with GCC-15 on MSYS2 (before I was accidentally building with GCC-13).