Skip to content

Prevent 'opam switch create <version>' from looking for packages mentioning any of the builtin eval-variables #6466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Prevent 'opam switch create <version>' from looking for packages mentioning any of the builtin eval-variables #6466

wants to merge 2 commits into from

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Apr 7, 2025 •
edited
Loading

Proposal 2 for making opam switch create <version> avoid ocaml-system coherently with the new behaviour of opam init introduced in #6307
Mentioned in #6407 (comment)
Proposal 1: #6465

Pros:

  • Does not affect custom repositories like Proposal 1
  • Simpler implementation compared to Proposal 1

Cons:

  • There isn't really any way to prevent this behaviour for people who want the old one, except if were to add an ugly option just for this

@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Apr 7, 2025
@kit-ty-kate kit-ty-kate mentioned this pull request Apr 7, 2025
Draft
@dra27 dra27 modified the milestones: 2.4.0~alpha1, 2.4.0~alpha2 Apr 14, 2025
@kit-ty-kate
Partially evaluate the available field with every builtin eval-variab…
14bac25 
…les set to the empty string when guessing the compiler based on the version number
@kit-ty-kate kit-ty-kate changed the title Prevent 'opam switch create <version>' from looking for packages mentioning the sys-ocaml-version variable Prevent 'opam switch create <version>' from looking for packages mentioning any of the builtin eval-variables Apr 22, 2025
@kit-ty-kate kit-ty-kate marked this pull request as ready for review April 22, 2025 22:41
@kit-ty-kate kit-ty-kate mentioned this pull request Apr 29, 2025
Draft
@kit-ty-kate kit-ty-kate removed this from the 2.4.0~alpha2 milestone Apr 29, 2025
@kit-ty-kate kit-ty-kate mentioned this pull request Apr 29, 2025
Merged
@kit-ty-kate kit-ty-kate marked this pull request as draft May 2, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AREA: DESIGN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kit-ty-kate @dra27