fix(electron): show no update dialog

ocavue · Jul 14, 2022 · 733f3c3 · 733f3c3
1 parent b6eff28
commit 733f3c3
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/.changeset/silver-eggs-smoke.md b/.changeset/silver-eggs-smoke.md
@@ -0,0 +1,5 @@
+---
+"@rino.app/editor": patch
+---
+
+Fix an issue that causes update dialog not to display when checking update manually.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -215,13 +215,21 @@ jobs:
 
       - name: Create draft GitHub release
         uses: softprops/action-gh-release@v1
-        if: ${{ github.ref == 'refs/heads/master' || github.ref == 'refs/heads/changeset-release/master' }}
+        if: ${{ github.ref == 'refs/heads/changeset-release/master' }}
         with:
           draft: true
           prerelease: false
           name: "${{ env.RINO_APP_VERSION }}"
           tag_name: "${{ env.RINO_APP_VERSION }}"
-          append_body: false
+
+      - name: Create prerelease GitHub release
+        uses: softprops/action-gh-release@v1
+        if: ${{ github.ref == 'refs/heads/master' }}
+        with:
+          draft: false
+          prerelease: true
+          name: "${{ env.RINO_APP_VERSION }}"
+          tag_name: "${{ env.RINO_APP_VERSION }}"
 
   release:
     runs-on: ubuntu-latest

diff --git a/packages/electron-main/src/updater.ts b/packages/electron-main/src/updater.ts
@@ -136,7 +136,7 @@ export async function checkForUpdatesAutomatically(): Promise<void> {
 
 export async function checkForUpdatesManually(): Promise<void> {
     const foundNewVersion = await checkForUpdatesAndNotify(true)
-    if (foundNewVersion) {
+    if (!foundNewVersion) {
         await showNoUpdateDialog()
     }
 }