-
Notifications
You must be signed in to change notification settings - Fork 23
A few improvements #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Valid OSD means not only that 'OSD-dimensions' property returns a table, but also that the values of this table are non-0
Avoids conflicts with other script within the same folder since it provides unique IDs
Avoids conflicts with other script within the same folder since it provides unique IDs
Avoids conflicts with other script within the same folder since it provides unique IDs
it sends messages to other scripts, so better load those earlier
Still not 100% correct as window scaling may emit two OSD property change events, so we trigger alignment on 2 non-zero OSD calls BUT: we can't differentiate whether this was auto-scaling-call on launch or a valid user call, so user's first manual alignment might get overriden by this fix
-1 left/down +1 right/up
Allows to set these in a better color space vs the default hex
reformat to tabular view add more image movement commands
How do you use this? I cant work out how to trigger MPVI to load for a video Cant see a keybind in the config that toggles it on/off. Tried resorting to just using your individual image position LUA since thats all I wanted and wanted to see if it fixed issues I had but it seems to not work if you try them individually without changes which IMO is worse than just keeping them all separated like they are currently. I get the convenience of profiles but there will likely be others like me who just wanted to grab one part of a script and use it without having to modify anything other than keybinds |
not sure I understand it, this is an image viewer, why are you trying to load for a video? |
In my fork I've made a few improvements listed below, so opening this PR in case you'd like to incorporate them into your repo as well:
mpvi
in bothmpv.conf
and andinput.conf
to allow people to just copy&paste configs to their own profilesYAML
(though an older version due to lua's outdated libraries) that also allows tabular formatting with comments and doesn't bug if you add a=
,
in92,92
, a space is fine (though it should be flexible and auto-detect,
as well)