fix(intelligence): store memory_type in metadata JSON column and enab…#910
Merged
Conversation
…le promotion
Root cause (three layers):
1. _create_memory_internal (infer=True path) never called on_add, so
memory_type was never set after intelligent add.
2. _simple_add merged extra_fields into top-level payload which OceanBase
silently drops — only the metadata JSON column is persisted.
3. on_get read memory.get("memory_type") which is always None since OceanBase
storage.get_memory() only surfaces 8 fixed fields, not top-level payload keys.
Fix:
- _create_memory_internal: call on_add and merge result into enhanced_metadata
- _simple_add / _simple_add_async: merge extra_fields into enhanced_metadata
instead of memory_data top-level
- on_get: normalize memory_type/access_count/importance_score from metadata
fallback; write all updates back through the metadata JSON column
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…le promotion
Root cause (three layers):
Fix: